HIVE-29600: Error message is too verbose in Metastore handler#6465
Merged
dengzhhu653 merged 1 commit intoapache:masterfrom May 9, 2026
Merged
HIVE-29600: Error message is too verbose in Metastore handler#6465dengzhhu653 merged 1 commit intoapache:masterfrom
dengzhhu653 merged 1 commit intoapache:masterfrom
Conversation
|
Contributor
|
@dengzhhu653 , verified the changes for the HIVE-29602 by running the schematool, this PR is working 👍🏻 |
Contributor
|
LGTM +1 (non-binding) |
Aggarwal-Raghav
approved these changes
May 8, 2026
wecharyu
approved these changes
May 9, 2026
Contributor
wecharyu
left a comment
wecharyu
left a comment
There was a problem hiding this comment.
LGTM, except one possible unrelated change.
| @Override | ||
| @Deprecated | ||
| public void create_database(final Database db) throws TException { | ||
| public final void create_database(final Database db) throws TException { |
Contributor
There was a problem hiding this comment.
nit: This change seems unrelated.
Member
Author
There was a problem hiding this comment.
yes, they are small improvements under the same parent Jira/task as well, so I put them together.
Member
Author
|
Thank you for the check and review, @Aggarwal-Raghav, @wecharyu ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?